Skip to content

Provide constants for Markdown formatter#4336

Merged
SougandhS merged 2 commits intoeclipse-jdt:masterfrom
SougandhS:markdownFormatingOptions
Sep 14, 2025
Merged

Provide constants for Markdown formatter#4336
SougandhS merged 2 commits intoeclipse-jdt:masterfrom
SougandhS:markdownFormatingOptions

Conversation

@SougandhS
Copy link
Copy Markdown
Member

@SougandhS SougandhS commented Aug 21, 2025

This commit provides constant and fields for markdown formatting enablement

partial fix :
#4335

What it does

How to test

Author checklist

Copy link
Copy Markdown
Member

@mateusz-matela mateusz-matela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far all the settings are explicitly set in setDefaultSettings() and setJavaConventionsSettings(), I'd keep that way unless there's a good reason not to.

@SougandhS SougandhS force-pushed the markdownFormatingOptions branch from 177882e to 15d4f01 Compare August 25, 2025 06:07
@SougandhS
Copy link
Copy Markdown
Member Author

So far all the settings are explicitly set in setDefaultSettings() and setJavaConventionsSettings(), I'd keep that way unless there's a good reason not to.

Included in both

@SougandhS SougandhS force-pushed the markdownFormatingOptions branch from 15d4f01 to 40e5942 Compare September 4, 2025 07:02
@eclipse-jdt-bot
Copy link
Copy Markdown
Contributor

eclipse-jdt-bot commented Sep 4, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.core/META-INF/MANIFEST.MF
org.eclipse.jdt.core/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From e2e59924642626f1ee96a7fd40cfe6ce7dcb629f Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <jdt-bot@eclipse.org>
Date: Sun, 7 Sep 2025 14:50:37 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/org.eclipse.jdt.core/META-INF/MANIFEST.MF b/org.eclipse.jdt.core/META-INF/MANIFEST.MF
index 5c61a69651..97424b91a4 100644
--- a/org.eclipse.jdt.core/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.core; singleton:=true
-Bundle-Version: 3.43.0.qualifier
+Bundle-Version: 3.43.100.qualifier
 Bundle-Activator: org.eclipse.jdt.core.JavaCore
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/org.eclipse.jdt.core/pom.xml b/org.eclipse.jdt.core/pom.xml
index e5103ad34a..9f31673ac2 100644
--- a/org.eclipse.jdt.core/pom.xml
+++ b/org.eclipse.jdt.core/pom.xml
@@ -17,7 +17,7 @@
     <version>4.38.0-SNAPSHOT</version>
   </parent>
   <artifactId>org.eclipse.jdt.core</artifactId>
-  <version>3.43.0-SNAPSHOT</version>
+  <version>3.43.100-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 
   <properties>
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@SougandhS SougandhS force-pushed the markdownFormatingOptions branch from 5f5f738 to 16eaead Compare September 7, 2025 14:47
@SougandhS
Copy link
Copy Markdown
Member Author

Hi @HannesWell
Is it okay to ignore this build failure and merge ?
https://github.com/eclipse-jdt/eclipse.jdt.core/pull/4336/checks?check_run_id=49808000452

image

@HannesWell
Copy link
Copy Markdown
Contributor

HannesWell commented Sep 8, 2025

Is it okay to ignore this build failure and merge ?
https://github.com/eclipse-jdt/eclipse.jdt.core/pull/4336/checks?check_run_id=49808000452

I'm not completly sure as I don't know that project very well and looking at it's pom it seems to be a bit special. So I cannot really tell if this is common issue. Maybe @iloveeclipse can help here as he created large parts of that projects build config?

Nevertheless I see a similar failure on the master branch of jdt.core and it looks again similar to the build problems I saw in the release preparation PR (but there I assumed it's a usual hick-up that can be investigated later):

And last but not least I see the following error currently in the eclipse.platform.releng.aggregator master build:
[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:5.0.0:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.jdt.core: Only qualifier changed for (org.eclipse.jdt.core/3.43.0.v20250908-1850). Expected to have bigger x.y.z than what is available in baseline (3.43.0.v20250820-1501) -> [Help 1]

This is not the very same eclipse-project/tycho-module but at least also from this repo and I wonder if this is related.

So TL;DR: I'm not sure yet, but I lean towards not ok.

@SougandhS SougandhS force-pushed the markdownFormatingOptions branch 3 times, most recently from 74c1964 to 0d36356 Compare September 11, 2025 05:44
Comment thread org.eclipse.jdt.core/META-INF/MANIFEST.MF Outdated
@iloveeclipse
Copy link
Copy Markdown
Member

Also please make sure you have rebased tha change on latest master

@SougandhS SougandhS force-pushed the markdownFormatingOptions branch 3 times, most recently from 863ad6f to a175349 Compare September 11, 2025 10:24
@iloveeclipse iloveeclipse force-pushed the markdownFormatingOptions branch from a175349 to 542b4e0 Compare September 11, 2025 21:25
@iloveeclipse iloveeclipse dismissed their stale review September 11, 2025 21:26

Versions OK now

This commit provides constant and fields for markdown formatting
enablement & Enable markdown formatting via setDefaultSettings() &
setJavaConventionsSettings()

partial fix :
eclipse-jdt#4335
@SougandhS SougandhS force-pushed the markdownFormatingOptions branch from 542b4e0 to d7463b5 Compare September 14, 2025 09:21
@SougandhS SougandhS merged commit 2cf8013 into eclipse-jdt:master Sep 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants